-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix harvest error with requires_model_validation #525
base: master
Are you sure you want to change the base?
Conversation
Addresses this error I ran into: > File > "/home/travis/build/ccnmtl/mediathread/ve/lib/python2.7/site-packages/django/core/management/base.py", > line 265, in __init__ > > '"requires_system_checks".' % self.__class__.__name__) > > django.core.exceptions.ImproperlyConfigured: Command Command defines > both "requires_model_validation" and "requires_system_checks", which is > illegal. Use only "requires_system_checks". > make: *** [harvest1] Error 1
Ah my bad, I saw that only in this PR: #527 (cf. my comment on it) |
the actual fix I made is 842d184 |
@gabrielfalcao lettuce is broken in Django 1.8 under the 0.2.23 release. Please merge this! |
+1 |
@nikolas and @m-vdb it would be interesting to make tox run in different versions of django too, so the tests would catch any error. I think the tox file should include something like that:
Maybe the requirements loaded during tests should strip out django to let the tox file define it. I can help you need. Tell me if you want I make a PR to your own #525 and #551 pull requests. |
If someone can resolve the conflicts on this, I can merge. |
Addresses this error I ran into with the new 0.2.23 release, introduced in the django 1.9 changes #522: