Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix harvest error with requires_model_validation #525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikolas
Copy link
Contributor

@nikolas nikolas commented Jul 28, 2016

Addresses this error I ran into with the new 0.2.23 release, introduced in the django 1.9 changes #522:

File
"/home/travis/build/ccnmtl/mediathread/ve/lib/python2.7/site-packages/django/core/management/base.py",
line 265, in init

 '"requires_system_checks".' % self.__class__.__name__)

django.core.exceptions.ImproperlyConfigured: Command Command defines
both "requires_model_validation" and "requires_system_checks", which is
illegal. Use only "requires_system_checks".
make: *** [harvest1] Error 1

Addresses this error I ran into:

>  File
>  "/home/travis/build/ccnmtl/mediathread/ve/lib/python2.7/site-packages/django/core/management/base.py",
>  line 265, in __init__
>
>      '"requires_system_checks".' % self.__class__.__name__)
>
> django.core.exceptions.ImproperlyConfigured: Command Command defines
> both "requires_model_validation" and "requires_system_checks", which is
> illegal. Use only "requires_system_checks".
> make: *** [harvest1] Error 1
@m-vdb
Copy link
Contributor

m-vdb commented Jul 28, 2016

Ah my bad, I saw that only in this PR: #527 (cf. my comment on it)

@m-vdb
Copy link
Contributor

m-vdb commented Jul 28, 2016

the actual fix I made is 842d184

@nikolas
Copy link
Contributor Author

nikolas commented Aug 10, 2016

@gabrielfalcao lettuce is broken in Django 1.8 under the 0.2.23 release. Please merge this!

@michelts
Copy link
Contributor

+1

@michelts
Copy link
Contributor

michelts commented May 23, 2017

@nikolas and @m-vdb it would be interesting to make tox run in different versions of django too, so the tests would catch any error. I think the tox file should include something like that:

envlist = py27-django{18,19,110,111}

[testenv]
deps =
    django18: Django>=1.8,<1.9
    django19: Django>=1.9,<1.10
    django110: Django>=1.10,<1.11
    django111: Django>=1.11,<2

Maybe the requirements loaded during tests should strip out django to let the tox file define it. I can help you need. Tell me if you want I make a PR to your own #525 and #551 pull requests.

@nikolas
Copy link
Contributor Author

nikolas commented May 23, 2017

@michelts yeah, i have a ticket for that here: #530

@skorokithakis
Copy link
Collaborator

If someone can resolve the conflicts on this, I can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants