Set up command construction to support generic iterables and mappings #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in working on #584.
Command.add_args_list()
previously had a misleading name and type annotation - it is used for accepting either a list or a single item. Renamed toCommand.add_args_iterable_or_single()
.Command.add_args_iterable()
for the case you know you're dealing with an iterable (more efficient than always creating a new list).utils.to_list()
to support generic iterables (still always returns a list, as per the name - my plan is to phase out its use where it's not needed).utils.format_dict_for_cli()
to support generic mappings.Command.add_args_mapping()
as a convenience that wrapsutils.format_dict_for_cli()
, which will allow tidying up code that constructs commands.Next step is to tidy up the components' code that constructs commands, allowing arguments to be
Iterable
andMapping
in place ofList
andDict
. With these changes it should be fairly straightforward, simply calling the correct method on theCommand
class.Here's an example of what upcoming changes look like: LewisGaul/python-on-whales@command-construction...command-construction-image