refactor: basic authentication with username:password encoded by base64

gabrielbsx · Mar 27, 2023 · 12487ad · 12487ad
1 parent e6f63ea
commit 12487ad
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.env.example b/.env.example
@@ -1 +1,2 @@
-BASIC=basic_token
+USERNAME=basic_username
+PASSWORD=basic_password
diff --git a/src/core/middleware/basic-authenticate.ts b/src/core/middleware/basic-authenticate.ts
@@ -4,9 +4,10 @@ import { env } from 'node:process'
 
 class BasicAuthenticate implements Middleware {
   async handle (request: Request): Promise<Either<Response<Error>, Response>> {
-    const [type, credentials] = request.headers?.authorization?.split(' ') ?? []
+    const [type, basicEncoded] = request.headers?.authorization?.split(' ') ?? []
     if (type === 'Basic') {
-      if (credentials === env.BASIC) {
+      const [username, password] = Buffer.from(basicEncoded, 'base64').toString().split(':')
+      if (username === env.USERNAME && password === env.PASSWORD) {
         return right(ok({ message: 'Authenticated' }))
       }
     }