Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some verbose print() calls #219

Merged
merged 4 commits into from
Dec 19, 2024
Merged

remove some verbose print() calls #219

merged 4 commits into from
Dec 19, 2024

Conversation

ManuelHu
Copy link
Contributor

I focused on the small number of print statements that are always triggered with our usage, but that do not provide any additional value to us.

I replaced the prints in the global scope with warnings or exceptions that are only triggered if the user attempts to use the data structures that depend on the imported modules.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 74.09%. Comparing base (ebbcc37) to head (f323975).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pyg4ometry/analysis/Data.py 38.46% 8 Missing ⚠️
src/pyg4ometry/visualisation/UsdViewer.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
- Coverage   74.12%   74.09%   -0.03%     
==========================================
  Files         157      157              
  Lines       22739    22752      +13     
==========================================
+ Hits        16855    16859       +4     
- Misses       5884     5893       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member

gipert commented Dec 19, 2024

Thanks @ManuelHu, I wanted to do this as well. I have opened #220, which is related. I'll merge and tag a new patch release since this is only about cosmetics.

@gipert gipert merged commit f0fddf1 into g4edge:main Dec 19, 2024
17 checks passed
@ManuelHu ManuelHu deleted the patch-2 branch December 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants