USD visOption pass through and manual #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
=======================================
Coverage 70.32% 70.33%
=======================================
Files 158 158
Lines 23618 23620 +2
=======================================
+ Hits 16610 16612 +2
Misses 7008 7008 ☔ View full report in Codecov by Sentry. |
ManuelHu
reviewed
Oct 26, 2024
| v.traverseHierarchy(reg.getWorldVolume()) | ||
| v.save() | ||
|
|
||
| `visOptions.color` and `visOptions.alpha` are passed though to the |
There was a problem hiding this comment.
This should be visOptions.colour instead of visOptions.color?
I think this would be important to fix in the docs, to not confuse users after the next release (it already is confusing enough that pyg4ometry uses colour and USD uses ...Color)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.