Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace print() statements with logging module calls #220

Open
gipert opened this issue Dec 19, 2024 · 4 comments
Open

Replace print() statements with logging module calls #220

gipert opened this issue Dec 19, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@gipert
Copy link
Member

gipert commented Dec 19, 2024

And uncomment this:

# "T20", # flake8-print

@gipert gipert added the enhancement New feature or request label Dec 19, 2024
@ManuelHu
Copy link
Contributor

I already have a large patch for some other print calls, where I

  • replace them with logging
  • or with exceptions
  • or remove them entirely....

But removing all of them is a huge amount of work, so I stopped at some point.

@gipert
Copy link
Member Author

gipert commented Dec 19, 2024

Do you have this WIP on some branch? Maybe you could open a draft PR and someone else can work on it at some point.

@ManuelHu
Copy link
Contributor

not yet, but I will try to get it up in the near future.

@stewartboogert
Copy link
Member

Happy to contribute to this once there is a WIP PR there is a mixture of IO, and there are some areas which logging is used others with a profusion of print. Moving to a more notebook environment, the printout is very annoying. I learned to program in the 80s and still love a print out, apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants