Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning on install of esbuild-style-plugin (sass stub types definition) #33

Open
nullbio opened this issue May 14, 2024 · 2 comments
Open

Comments

@nullbio
Copy link

nullbio commented May 14, 2024

Getting the following warning on yarn install for version 1.6.3:

warning esbuild-style-plugin > @types/[email protected]: This is a stub types definition. sass provides its own type definitions, so you do not need this installed.

Is it related to this? bb3a749

utils.ts file change, previous sass issues resulted in a merge that changed the code to this:

return (moduleName == 'sass') ? (await import(moduleName)) : (await import(moduleName)).default

But now that is gone.

Or is this a different error entirely? I don't know enough about this ecosystem to debug and/or suggest a solution, but wanted to raise this to your attention. Thanks.

@nullbio
Copy link
Author

nullbio commented May 14, 2024

Ah, seems this merge request fixes it: #28

How can we get this pulled?

@nullbio
Copy link
Author

nullbio commented May 14, 2024

Seems the author of this package isn't actively maintaining this anymore, so I've created a fork with the most recent bug fixes here:

https://www.npmjs.com/package/esbuild-style-plugin-v2

Just replace the import name and package name in your package.json (add -v2) and it should all work without the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant