Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typescript type resolution #8662

Merged
merged 5 commits into from
May 27, 2024
Merged

Conversation

tracernz
Copy link
Member

Fixes #[issue_no]

Summary of Changes

Most of our tsconfigs override typeRoots, which stops typescript from finding types in node_modules. Notably that prevented the jest types from being found so our tests were all red squiggles with no hints. This PR adds node_modules/@types to the typeRoots. There was also an issue with one of our dependencies (esbuild-style-plugin) requiring a @types/sass package which is malformed/empty, and caused typescript to complain about the typing config. The package seems to be unmaintained so we move to a fork that removes this useless dependency: g45t345rt/esbuild-style-plugin#33.

Now our jest tests having typings.

As this PR only shuffles some typing deckchairs there is no QA.

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

None required.

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo or flybywire-aircraft-a380-842 download link at the bottom of the page

@tracernz tracernz added this to the v0.12.0 milestone May 26, 2024
@tracernz tracernz requested a review from Benjozork May 26, 2024 05:18
@tracernz tracernz enabled auto-merge (squash) May 27, 2024 00:39
@tracernz tracernz merged commit 1a6e658 into flybywiresim:master May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

2 participants