Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[issue_no]
Summary of Changes
Most of our tsconfigs override typeRoots, which stops typescript from finding types in node_modules. Notably that prevented the jest types from being found so our tests were all red squiggles with no hints. This PR adds node_modules/@types to the typeRoots. There was also an issue with one of our dependencies (
esbuild-style-plugin
) requiring a@types/sass
package which is malformed/empty, and caused typescript to complain about the typing config. The package seems to be unmaintained so we move to a fork that removes this useless dependency: g45t345rt/esbuild-style-plugin#33.Now our jest tests having typings.
As this PR only shuffles some typing deckchairs there is no QA.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
None required.
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.