Enable support for Jazzy / Drop support for Foxy #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @firesurfer for this contribution! I'll have a look. |
stefanscherzinger
force-pushed
the
jazzy
branch
from
cd15e03
to
9ccf2e7
Compare
Also update the build badges.
stefanscherzinger
force-pushed
the
jazzy
branch
from
5edab7e
to
8e78b61
Compare
Also use the topic-based `controller_manager` configuration.
stefanscherzinger
force-pushed
the
jazzy
branch
from
a2e12df
to
b3a12c5
Compare
stefanscherzinger
force-pushed
the
jazzy
branch
from
b3a12c5
to
32e1b3a
Compare
stefanscherzinger
merged commit f53f798
into
fzi-forschungszentrum-informatik:ros2
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for Jazzy by dropping support for Foxy.
As foxy is not being supported anymore we can remove the whole
ifdefconditional compilation. Since humble the controller interfaces haven't changed. Therefore this code should compile on every release between Humble and Jazzy. (I tested it so far only on Jazzy)I left the CMake Ros Version handling in the code on purpose in case we need to implement switches in the future.
Edit:
@firesurfer I'll add some steps:
controller_managerinitializationrobot_descriptionfrom the controller's base class for Jazzy