Add artifactUri, thumbnailUri, and displayUri to top level of Objkt #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciphrd
requested changes
Sep 24, 2022
src/Resolver/ObjktResolver.ts
Outdated
| }) | ||
| thumbnailUri(@Root() objkt: Objkt, @Ctx() ctx: RequestContext) { | ||
| if (objkt.thumbnailUri) return objkt.thumbnailUri; | ||
| return ctx.genTokLoader.load(objkt.metadata?.thumbnailUri); |
There was a problem hiding this comment.
The genTokLoader is a DataLoader designed to batch queries to get a Generative Token from the database. Its load function accepts a Generative Token ID.
Ultimately, requesting the DataLoader in here is not required, as the data is already available in objkt.metadata.thumbnailUri already stored in memory at this point of execution.
src/Resolver/ObjktResolver.ts
Outdated
| }) | ||
| displayUri(@Root() objkt: Objkt, @Ctx() ctx: RequestContext) { | ||
| if (objkt.displayUri) return objkt.displayUri; | ||
| return ctx.genTokLoader.load(objkt.metadata?.displayUri); |
There was a problem hiding this comment.
Same remark as thumbnailUri
src/Resolver/ObjktResolver.ts
Outdated
| @FieldResolver((returns) => String, { | ||
| description: "IPFS uri pointing to the web page hosting the Generator code.", | ||
| }) | ||
| artifactUri(@Root() objkt: Objkt, @Ctx() ctx: RequestContext) { |
There was a problem hiding this comment.
This resolver should be removed as it can be derived from the Generative Token generativeUri and the objkt generationHash
https://gateway.fxhash.xyz/ipfs/${cid(generativeUri)}/?fxhash=${generationHash}
- Remove artificatUri - Remove Data Loader wrapper for displayUri and thumbnailUri
|
Addressed PR feedback with latest commit. Thanks for your help here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to update
Objktto supplyartifactUri,thumbnailUri, anddisplayUrioutside of themetadatafield. These are very common fields and nesting them only withinmetadatais problematic because it requires loading the entiremetadatafield to access them. Metadata can be huge for someObjkts because it contains the description of the project and a lot of other data that is not necessarily always needed.I wasn't able to fully test this because I had issues getting the Docker container up and running:
#31
#27