Add set_token_name to SFT pallet #914
Open
+309
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zees-dev
reviewed
Jan 7, 2025
Comment on lines
+425
to
+428
| let mut token_info = TokenInfo::<T>::get(token_id).ok_or(Error::<T>::NoToken)?; | ||
| token_info.token_name = token_name.clone(); | ||
|
|
||
| TokenInfo::<T>::insert(token_id, token_info); |
There was a problem hiding this comment.
nit: can get and set - using mutate:
TokenInfo::<T>::try_mutate(token_id, |maybe_token_info| -> DispatchResult {
let token_info = maybe_token_info.as_mut().ok_or(Error::<T>::NoToken)?;
token_info.token_name = token_name.clone();
Ok(())
})?;
zees-dev
reviewed
Jan 7, 2025
| set_token_name { | ||
| let owner = account::<T>("Alice"); | ||
| let token_id = build_token::<T>(Some(owner.clone()), 1); | ||
| let token_name = bounded_string::<T>("Token"); |
There was a problem hiding this comment.
should test max string limit as that would be testing upperbound of the extrinsic weight
zees-dev
reviewed
Jan 7, 2025
| use super::*; | ||
|
|
||
| #[test] | ||
| fn set_name_works() { |
There was a problem hiding this comment.
would also be good to validate event is emitted as part of this success test
zees-dev
reviewed
Jan 7, 2025
zees-dev
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context & Background
Related Issues
Release Notes
Key Changes
Type of Change
Extrinsic Changes
Added
Event Changes
Added