Migrate token ownership to separate storage map #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surangap
reviewed
Nov 21, 2023
| @@ -280,13 +280,13 @@ where | |||
| current_owner: &T::AccountId, | |||
| new_owner: &T::AccountId, | |||
| ) -> DispatchResult { | |||
| let collection_info = pallet_nft::CollectionInfo::<T>::get(collection_id) | |||
| let ownership_info = pallet_nft::OwnershipInfo::<T>::get(collection_id) | |||
There was a problem hiding this comment.
wonder if we can remove this FuturepassMigrator code now. maybe in a separate PR.
…-ownership # Conflicts: # pallet/nft/src/types.rs # runtime/src/migrations/mod.rs
surangap
reviewed
Nov 22, 2023
| // Construct ownership info out of old ownership info | ||
| let token_ownership_old = collection_info.owned_tokens; | ||
| let mut token_ownership_new = TokenOwnership::default(); | ||
| token_ownership_old.iter().for_each(|ownership| { |
There was a problem hiding this comment.
What are the maximum entries we expect here for the largest collection on mainnet?. might need to do a simple calculation for the memory requirement?
fork testing on mainnet with prod hardware constraint would also do.
surangap
reviewed
Nov 22, 2023
Comment on lines
+189
to
+195
| let collection_id_key = Twox64Concat::hash(&collection_id.encode()); | ||
| Map::unsafe_storage_put::<TokenOwnership<AccountId, MaxTokensPerCollection>>( | ||
| b"Nft", | ||
| b"OwnershipInfo", | ||
| &collection_id_key, | ||
| token_ownership_new, | ||
| ); |
There was a problem hiding this comment.
can't we use normal put here?
surangap
reviewed
Nov 22, 2023
…-ownership # Conflicts: # pallet/nft/src/tests.rs
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves token ownership in the NFT pallet to it's own map. This allows for easier querying of the collection_info struct and avoids massive delays when querying large sets of data. The owned_tokens RPC call should be used to get ownership information for individual accounts.
Jira link: TRN-240
Note, also fixes TRN-225