Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use get or throw to get some env vars #189

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

use get or throw to get some env vars #189

wants to merge 3 commits into from

Conversation

SametSahin10
Copy link
Contributor

  • use getOrThrow to get some environment vars, add log statements
  • delete an env var description
  • remove unused lines, fields

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 1, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

NikolayRn
NikolayRn approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@NikolayRn NikolayRn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolayRn NikolayRn NikolayRn approved these changes

@leonprou leonprou Awaiting requested review from leonprou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SametSahin10 @NikolayRn