-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lexical-markdown] Add test to keep code language #37
base: cloned_main_fb6a1
Are you sure you want to change the base?
Conversation
Clone of the PR facebook/lexical#6259 |
My review is in progress 📖 - I will have feedback for you in a few minutes! |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed your code and did not find any issues!
Please note that I can make mistakes, and you should still encourage your team to review your code as well.
[lexical-markdown] Bug Fix: preserve language tag for Markdown code
Right now, PR contains only one commit with tests to highlight the problem.
If the markdown file contains a code block with an unsupported language (a language for which the project doesn't have syntax highlighter) the lexical will remove any information about that language.
Let's say we have markdown with the following content:
If we don't have
prism-rust
in the project, lexical will strip all the info about the language and saved file will look like:That behavior seems to me like a bug.
Possible solution
I think
CodeNode
should always keep__language
field, no matter what themapToPrismLanguage()
returns. And we can create another field called__isSyntaxHighlightSupported
for highlighting check.What do you think? I'll be happy to create another commit with a fix if provided solution works for the lexical team.
Description by Korbit AI
What change is being made?
Add unit tests to ensure that the code language is preserved in markdown conversion within the
LexicalMarkdown
package.Why are these changes being made?
These changes are made to verify that the markdown conversion process correctly retains the specified code language, ensuring accurate syntax highlighting and language-specific formatting in the output. This addresses potential issues where the language might be lost or incorrectly handled during conversion.