[Lexical][UI Gallery] Fix meta lexical website intern build errors #35

local-dev-korbit-ai-mentor · 2024-08-15T17:39:40Z

WHAT

Fix meta lexical website intern build errors

Packages/APIs are not imported as is to "Meta Intern". Hence have lexical.dev external links for opening those from intern meta build for lexical website.
same for error codes, don't include this page in intern meta build

WHY

working on a prototype for UI Gallery which can work for both Intern/Extern Lexical Website

TEST

tested locally, everything works as is for Extern Lexical Website

Description by Korbit AI

Note

This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?

Conditionally load internal packages and plugins based on the FB_INTERNAL environment variable to fix build errors on the meta lexical website.

Why are these changes being made?

The build errors occur due to the inclusion of internal packages and plugins that are not available in the public build environment. This change ensures that these internal dependencies are only loaded when the FB_INTERNAL environment variable is set, preventing build failures in public environments.

…ages and apis related autogenerated docs

local-dev-korbit-ai-mentor · 2024-08-15T17:39:41Z

Clone of the PR facebook/lexical#6300

korbit-ai · 2024-08-15T17:39:43Z

My review is in progress 📖 - I will have feedback for you in a few minutes!

coderabbitai · 2024-08-15T17:39:45Z

Warning

Rate limit exceeded

@furwellness has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 28 minutes and 23 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 4cbb85f and f68d1f6.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

korbit-ai

I have reviewed your code and found 1 potential issue.

korbit-ai · 2024-08-15T17:48:04Z

packages/lexical-website/sidebars.js

+    process.env.FB_INTERNAL
+      ? {
+          href: 'https://lexical.dev/docs/packages/lexical',
+          label: 'Packages',
+          type: 'link',
+        }
+      : {
+          items: [
+            {
+              dirName: 'packages',
+              type: 'autogenerated',
+            },
+          ],
+          label: 'Packages',
+          type: 'category',
        },


The conditional rendering based on process.env.FB_INTERNAL is a good approach for differentiating between internal and external builds. However, it's important to ensure that this environment variable is always defined to avoid potential runtime errors. Consider adding a default value or error handling for cases where FB_INTERNAL might be undefined. For example, you could use a default value like this: process.env.FB_INTERNAL === 'true' to ensure it's always a boolean value.

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

furwellness · 2024-08-16T06:36:18Z

/review

codiumai-pr-agent-free · 2024-08-16T06:36:32Z

PR Reviewer Guide 🔍

(Review updated until commit `f68d1f6`)

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Key issues to review Code Redundancy The conditional logic for `FB_INTERNAL` is repeated multiple times throughout the configuration file. Consider refactoring this into a single function or configuration object to improve maintainability and reduce redundancy. Potential Null Reference The use of `.filter((plugin) => plugin != null)` at line 272 suggests that null values are expected in the plugins array. Ensure that this handling is intentional and consider if there's a cleaner way to manage conditional plugin inclusion.

github-actions · 2024-08-16T06:37:10Z

Persistent review updated to latest commit f68d1f6

furwellness · 2024-08-17T13:09:50Z

@coderabbitai review

coderabbitai · 2024-08-17T13:09:54Z

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

furwellness · 2024-08-21T17:07:27Z

@coderabbitai full review

coderabbitai · 2024-08-21T17:07:31Z

Actions performed

Full review triggered.

furwellness · 2024-08-21T18:12:30Z

No comment from coderabbit

Sahejkm and others added 2 commits June 12, 2024 13:27

[Lexical][Meta] Fix errors in intern meta static docs related to pack…

02f4797

…ages and apis related autogenerated docs

[skip ci]

f68d1f6

local-dev-korbit-ai-mentor bot added the issue-evaluation label Aug 15, 2024

korbit-ai bot added the korbit-code-analysis label Aug 15, 2024

korbit-ai bot reviewed Aug 15, 2024

View reviewed changes

codiumai-pr-agent-free bot added the Review effort [1-5]: 2 label Aug 16, 2024

github-actions bot added Review effort [1-5]: 3 and removed Review effort [1-5]: 2 labels Aug 16, 2024

furwellness changed the base branch from cloned_main_25ba4 to main August 21, 2024 17:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Lexical][UI Gallery] Fix meta lexical website intern build errors #35

[Lexical][UI Gallery] Fix meta lexical website intern build errors #35

local-dev-korbit-ai-mentor bot commented Aug 15, 2024 •

edited by korbit-ai bot

Loading

local-dev-korbit-ai-mentor bot commented Aug 15, 2024

korbit-ai bot commented Aug 15, 2024

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

korbit-ai bot left a comment

korbit-ai bot Aug 15, 2024

furwellness commented Aug 16, 2024

codiumai-pr-agent-free bot commented Aug 16, 2024 •

edited by github-actions bot

Loading

github-actions bot commented Aug 16, 2024

furwellness commented Aug 17, 2024

coderabbitai bot commented Aug 17, 2024

furwellness commented Aug 21, 2024

coderabbitai bot commented Aug 21, 2024

furwellness commented Aug 21, 2024

[Lexical][UI Gallery] Fix meta lexical website intern build errors #35

Are you sure you want to change the base?

[Lexical][UI Gallery] Fix meta lexical website intern build errors #35

Conversation

local-dev-korbit-ai-mentor bot commented Aug 15, 2024 • edited by korbit-ai bot Loading

WHAT

WHY

TEST

Description by Korbit AI

What change is being made?

Why are these changes being made?

local-dev-korbit-ai-mentor bot commented Aug 15, 2024

korbit-ai bot commented Aug 15, 2024

coderabbitai bot commented Aug 15, 2024 • edited Loading

Rate limit exceeded

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

korbit-ai bot left a comment

Choose a reason for hiding this comment

korbit-ai bot Aug 15, 2024

Choose a reason for hiding this comment

furwellness commented Aug 16, 2024

codiumai-pr-agent-free bot commented Aug 16, 2024 • edited by github-actions bot Loading

PR Reviewer Guide 🔍

(Review updated until commit f68d1f6)

github-actions bot commented Aug 16, 2024

furwellness commented Aug 17, 2024

coderabbitai bot commented Aug 17, 2024

furwellness commented Aug 21, 2024

coderabbitai bot commented Aug 21, 2024

furwellness commented Aug 21, 2024

local-dev-korbit-ai-mentor bot commented Aug 15, 2024 •

edited by korbit-ai bot

Loading

coderabbitai bot commented Aug 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codiumai-pr-agent-free bot commented Aug 16, 2024 •

edited by github-actions bot

Loading

(Review updated until commit `f68d1f6`)