Bug Fix: Fix selection when hitting "shift+arrowdown" into a table.

[local-dev-korbit-ai-mentor]

Pressing "Shift+ArrowDown" into a table selects only up to the first table-cell node and its children, even though the whole table appears selected.

Description

Previously, the new focus would be set on the table's parent if the current selection was partially within a table. Now, it will be on the first/last cell of the table.

Closes #6273

Before

screencast-playground.lexical.dev-2024.06.07-14_50_45.webm

After

screencast-localhost_3000-2024.06.07-15_27_25.webm

Description by Korbit AI

Note

This feature is in early access. You can enable or disable it in the Korbit Console.

What change is being made?

Fix the selection behavior when hitting "shift+arrowdown" into a table by updating the selection logic and adding an end-to-end test.

Why are these changes being made?

The previous implementation did not correctly handle the selection when extending it into a table, causing incorrect selection behavior. This fix ensures that the entire table is selected as expected, improving the user experience and maintaining consistency in selection operations.

Summary by CodeRabbit

• New Features

  • Enhanced table selection logic for a more intuitive user experience when selecting cells within a table.

• Bug Fixes

  • Added a test case to ensure keyboard shortcuts (Shift + ArrowDown) correctly select entire tables, improving reliability in user interactions.

[local-dev-korbit-ai-mentor]

Clone of the PR facebook/lexical#6274

[korbit-ai]

My review is in progress 📖 - I will have feedback for you in a few minutes!

[coderabbitai]

Walkthrough

This update enhances the keyboard selection capabilities of tables within the editor. A new test case has been added to verify that users can select an entire table using the Shift + ArrowDown shortcut. Additionally, the selection logic for table cells has been improved, allowing for more precise focus handling when selecting cells. These changes collectively ensure a more robust and user-friendly experience in managing table interactions.

Changes

File	Change Summary
packages/lexical-playground/__tests__/e2e/Selection.spec.mjs	Added a test case for selecting a whole table with Shift + ArrowDown, enhancing keyboard interaction coverage.
packages/lexical-table/src/LexicalTableSelectionHelpers.ts	Improved applyTableHandlers function to accurately compute focus on the first and last cell nodes for better selection handling in tables.

Poem

🐇 In the editor's realm where tables grow,
A leap with a shift makes selections flow.
Cells align as focus finds its way,
A dance of interaction, brightening the day!
With each test added, our joy takes flight,
Hopping through code, everything feels right! 🥕✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[korbit-ai]

I have reviewed your code and did not find any issues!

---

Please note that I can make mistakes, and you should still encourage your team to review your code as well.

[furwellness]

/review

[furwellness]

@coderabbitai review

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

(Review updated until commit 58f7fdb)

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Code Complexity The new logic for handling table selection is significantly more complex than the previous implementation. This could increase the maintenance burden and potential for bugs. Consider simplifying the logic or adding more detailed comments to explain the complex parts.

[coderabbitai]

Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[github-actions]

Persistent review updated to latest commit 58f7fdb

[furwellness]

@coderabbitai full review

[coderabbitai]

Actions performed

Full review triggered.

[furwellness]

@coderabbitai full review

[coderabbitai]

Actions performed

Full review triggered.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4cbb85f and 58f7fdb.

Files selected for processing (2)

• packages/lexical-playground/tests/e2e/Selection.spec.mjs (1 hunks)
• packages/lexical-table/src/LexicalTableSelectionHelpers.ts (1 hunks)

Additional comments not posted (2)

packages/lexical-playground/__tests__/e2e/Selection.spec.mjs (1)

719-737: New test case added for table selection.

The new test case for selecting a whole table using Shift + ArrowDown is well-implemented. It correctly verifies the selection behavior by checking the anchor and focus offsets and paths.

packages/lexical-table/src/LexicalTableSelectionHelpers.ts (1)

719-728: Improved table selection logic using $computeTableMap.

The use of $computeTableMap to determine the first and last cell nodes enhances the precision of the selection logic. This change ensures that the focus is set accurately, improving user experience during table interactions.

[furwellness]

Zero comments from coderabbit