-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UKRにおいて潜在変数と写像を描画するメソッドを追加 #137
Open
ae14watanabe
wants to merge
84
commits into
master
Choose a base branch
from
136_add_view_in_ukr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+545
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
欲を言えばやりたいこと
|
tsuno0829
previously approved these changes
May 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is_show_all_label_dataの部分も変更してみましたがこちらのPCでも問題なく動作しました.
津野的には問題ないと思いますのでapproveします!
@tsuno0829 レビューしてもらったのに申し訳ないんだけど、内部の描画のメソッドをpcolormeshからimshowに変更してみたので、結果に違いがないかだけ確認してもらえませんか?お願いします! |
ちょっと自分で結果見てたらなんかおかしいので、reviewタンマで。良さそうだったらdraft解除します。 |
修正しました。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 説明
close #136
UKRで学習した潜在変数と写像を描画するメソッドをモデルに追加。
fit済みのインスタンス ukrに対して
ukr.visualize()
を実行すると描画が行われる。backendは
TkAgg
のみ挙動するようになっており、事前にmatplotlibがimportされているとうまく動かないことに注意。オプションの引数などの仕様については 5343e0f を参照のこと。
動物データで動作させた結果。左側が潜在空間、右側が特徴量の成分を表示するバー。これは初期状態(バーはデータの平均を表示するようにしている)
左側の任意の座標をクリックすると、その座標の写像先の成分を右で表示する
特定のバーを指定すると、その次元の値で左の潜在空間を着色する
Type of change 変更の種類
How Has This Been Tested? どのようにテストしたか?
tutorials/ukr/fitting_animal.py
を実行Reviewerへの依頼
作業To-do