Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -P argument, to look for updates when processing pending reports #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garbled1
Copy link
Contributor

Patch 2/4: This calls report.process with an argument of True instead of false when doing a report process. This allows me to patch a host, send a report to patchman, and then immediately recompute that one host to see if there are missing patches.

@furlongm
Copy link
Owner

The only issue I have with this is that if the repos don't exist, it pretends to find updates but won't find them, because there are no repos. That was why I delayed adding this before.

@garbled1
Copy link
Contributor Author

I'm not sure I understand the scenario, but is it acceptable to just document that behaviour?

@furlongm
Copy link
Owner

Yes possibly we could just document it. The first time a host reports a repo that does not previously exist, then it will not find the updates, because that repo needs to update it's mirrors first.

@garbled1
Copy link
Contributor Author

I think per your own documentation you suggest that the full update (with the -a) be done daily, which should take care of the issue. If properly maintained like that, all my request does is let you immediately see updates in the data.

@furlongm
Copy link
Owner

Note that if you set up celery per the installation docs, the report processing automatically finds updates when a report is received. That was the original intention for having the find_updates argument to report.process().

It seems like it would also do exactly what you want it to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants