feat: 166: Add proxy dialer support. #481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I have not ported any of the tests over, but I can do that if this approach is preferable to #480. |
dragonsinth
reviewed
Sep 11, 2024
| } | ||
|
|
||
| // NOTE: Use net.Dialer to avoid dependency on grpc-go's internal package | ||
| // conn, err := internal.NetDialerWithTCPKeepalive().DialContext(ctx, "tcp", newAddr) |
There was a problem hiding this comment.
do we need to then manually set keepalive?
There was a problem hiding this comment.
I don't think so. The current grpcurl dialer doesn't set keepalive and the grpc-go dailer only sets keepalive for select platforms, others get a vanilla dialer.
dragonsinth
reviewed
Sep 11, 2024
| @@ -37,6 +37,8 @@ import ( | |||
| "google.golang.org/protobuf/types/known/structpb" | |||
| ) | |||
|
|
|||
| var GrpcurlUA string | |||
|
|
|||
There was a problem hiding this comment.
this seems.... unfortunate...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the internal
grpc-godialer with proxy support into thegrpcurlpackage such thatgrpcurlcan support idiomatic proxy configuration via theHTTPS_PROXYenvironment variable. The port does have a minor modification in that it uses the standard lib'snet.Dialerrather than theNetDialerWithTCPKeepalivefrom thegrpc-go's internal package.This is an alternative to PR #480.
Addresses #166.