Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly initialise gRPCurl text area #340

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/resources/webform/webform.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,6 @@ window.initGRPCForm = function(services, svcDescs, mtdDescs, invokeURI, metadata
// set raw request text
updateJSONRequest(requestObj);

// init grpcCurl text
updateCurlCommand(requestObj);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part actually seems fine since updateJSONRequest calls this internally

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dragonsinth can you clarify please. The call to updateCurlCommand is not required here, since updateJSONRequest will do that. So removing this call actually fixes the issue.

// enable the invoke button
resetInvoke(true);

Expand Down