Improve error message when a map passed by mistake as a child to fragment #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment ... or to ErrorBoundary (which uses comp/fragment). Without this change, we assume the map is props, and end up getting a _warning_ like "Warning: Invalid prop `some-prop...` supplied to `React.Fragment`. React.Fragment can only have `key` and `children` props." With this change, we get a proper _error_ about trying to render the wrong type, and in which component.
|
Testing: A simple app where Root has an arbitrary map as its body. Of course a disadvantage of this change is that if fragment adds support for more properties in the future then we'd need to update the code. I am not sure whether we want to accept the risk or not. |
awkay
reviewed
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... or to ErrorBoundary (which uses comp/fragment).
Without this change, we assume the map is props, and end up getting a warning like "Warning: Invalid prop
some-prop...supplied toReact.Fragment. React.Fragment can only havekeyandchildrenprops."With this change, we get a proper error about trying to render the wrong type, and in which component.
WHY: The warning makes it harder to understand what the actual problem is.