Fix compilation against musl libc #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stintel
commented
Mar 30, 2024
•
stintel
commented
- usr: do not rely on non-portable __WORDSIZE
- usr: do not rely on LFS64 interfaces
- CI: build on Alpine Linux
The __WORDSIZE macro is not properly documented anywhere. Relying on it causes a compile error.s on systems using musl libc. POSIX defines LONG_BIT; use that instead. Signed-off-by: Stijn Tintel <[email protected]>
LFS64 interfaces are non-standard. Relying on them causes multiple compile errors on systems using musl libc 1.2.4 or later. They could be worked around by defining _LARGEFILE64_SOURCE, but this only a short term workaround, and will be removed in a future musl version. Instead, define _FILE_OFFSET_BITS as 64, which makes all interfaces on glibc 64-bit by default, and replace the non-standard interfaces with the standard ones. This replaces all occurences of fstat64 with fstat, lseek64 with lseek, pread64 with pread, pwrite64 with pwrite, and stat64 with stat. Signed-off-by: Stijn Tintel <[email protected]>
Add a CI step to build on Alpine Linux, to avoid future breakage on systems running musl libc. Signed-off-by: Stijn Tintel <[email protected]>
|
ping @fujita |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.