Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clean up systemd tgt.service unit file #41

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fix and clean up systemd tgt.service unit file #41

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
751f8fd
tgtd.service: Fix Documentation URI
JohnAZoidberg Jul 29, 2019
d679a99
tgtd.service: Don't fork but notify
JohnAZoidberg Jul 29, 2019
eb83fc5
tgtd.service: Run tgt-admin verbose
JohnAZoidberg Jul 29, 2019
16a544d
tgtd.service: Remove getty comment
JohnAZoidberg Jul 29, 2019
bbb40d0
tgtd.service: Kill tgtd after targets were deleted
JohnAZoidberg Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions scripts/tgtd.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,31 +1,28 @@
[Unit]
Description=iSCSI target framework daemon
Documentation=man: tgtd(8)
Documentation=man:tgtd(8)
After=network.target

# On systems without virtual consoles, don't start any getty. Note
# that serial gettys are covered by [email protected], not this
# unit.
ConditionPathExists=/etc/tgt/targets.conf

[Service]
Type=forking
Type=notify
Environment=TGTD_CONFIG=/etc/tgt/targets.conf

ExecStart=/usr/sbin/tgtd
ExecStartPost=/usr/sbin/tgtadm --op update --mode sys --name State -v offline
ExecStartPost=/usr/sbin/tgtadm --op update --mode sys --name State -v ready
ExecStartPost=/usr/sbin/tgt-admin -e -c ${TGTD_CONFIG}
ExecStart=/usr/sbin/tgtd --foreground
ExecStartPost=/usr/sbin/tgtadm --op update --mode sys --name State --value offline
ExecStartPost=/usr/sbin/tgtadm --op update --mode sys --name State --value ready
ExecStartPost=/usr/sbin/tgt-admin --verbose --execute --conf ${TGTD_CONFIG}

ExecReload=/usr/sbin/tgt-admin --update ALL -f -c ${TGTD_CONFIG}
ExecReload=/usr/sbin/tgt-admin --verbose --update ALL --force --conf ${TGTD_CONFIG}

ExecStop=/usr/sbin/tgtadm --op update --mode sys --name State -v offline
ExecStop=/usr/sbin/tgt-admin --offline ALL
ExecStop=/usr/sbin/tgt-admin --update ALL -c /dev/null -f
ExecStop=/usr/sbin/tgtadm --op update --mode sys --name State --value offline
ExecStop=/usr/sbin/tgt-admin --verbose --offline ALL
ExecStop=/usr/sbin/tgt-admin --verbose --update ALL --force --conf /dev/null
ExecStop=/usr/sbin/tgtadm --op delete --mode system
ExecStop=/usr/sbin/kill -9 $MAINPID
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure this is needed? I run tgtd with foreground in a container. And stopping it via https://github.com/fujita/tgt/pull/41/files#diff-f589b6bd883ba54cbe2ebfc7b864d73fde17e245a48cf272fcf8dc9b37ac4969R19-R21 definitely stops the whole process.


# Exit code: 107 tgtd not running

# ExecStop exit code: 107 tgtd not running

[Install]
WantedBy=multi-user.target