Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple test suite for doing downstream tests #390

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

mariusvniekerk
Copy link
Collaborator

No description provided.

@martindurant
Copy link
Member

Does this need to be merged before the first tests would run?

@mariusvniekerk
Copy link
Collaborator Author

Yep it does

@martindurant
Copy link
Member

Can we please do this in two stages, one to add the CI, and then another to add the tests?

@jorisvandenbossche
Copy link

@mariusvniekerk do the tests actually pass at the moment?

@mariusvniekerk
Copy link
Collaborator Author

Rebased to put it into the ci.yml to see if they would trigger.

@mariusvniekerk
Copy link
Collaborator Author

They don't :(

@martindurant
Copy link
Member

The run is here: https://github.com/mariusvniekerk/s3fs/actions/runs/410872762

but apparently there is a syntax problem

@mariusvniekerk
Copy link
Collaborator Author

There we go

@martindurant
Copy link
Member

That's a lot of "❌"!

@mariusvniekerk
Copy link
Collaborator Author

How big do we want the test matrix to be?

@martindurant
Copy link
Member

Er, it does seem like a lot. It would be enough to be python versions on linux and one version for win. I wouldn't even bother with osx...

Note that fsspec runs the s3fs test suite on all CI runs, and dask does indeed have a couple of s3 tests.

Base automatically changed from master to main February 11, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants