-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a simple test suite for doing downstream tests #390
base: main
Are you sure you want to change the base?
Conversation
Does this need to be merged before the first tests would run? |
Yep it does |
Can we please do this in two stages, one to add the CI, and then another to add the tests? |
@mariusvniekerk do the tests actually pass at the moment? |
1d7c033
to
0d19474
Compare
Rebased to put it into the ci.yml to see if they would trigger. |
They don't :( |
The run is here: https://github.com/mariusvniekerk/s3fs/actions/runs/410872762 but apparently there is a syntax problem |
0d19474
to
3b4b4d1
Compare
There we go |
That's a lot of "❌"! |
How big do we want the test matrix to be? |
Er, it does seem like a lot. It would be enough to be python versions on linux and one version for win. I wouldn't even bother with osx... Note that fsspec runs the s3fs test suite on all CI runs, and dask does indeed have a couple of s3 tests. |
No description provided.