-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
@ncave I can do another one for you, once you've fixed the CI failures |
@cloudRoutine Can you do one without this PR, that works too. Thanks a lot! |
{ | ||
"title": "F# String Response Generator - dotnet cli tool", | ||
"version": "3.3.0", | ||
"authors": ["Don Syme","Enrico Sada","Jared Hester"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to move these too, they'll be added to the .nuspec
generated by dotnet pack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
global.json
Outdated
@@ -1,4 +0,0 @@ | |||
{ | |||
"projects": [ "src", "test" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't delete this file, specify the dotnet cli version in it
<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<OutputType>Exe</OutputType> | ||
<TargetFramework>netcoreapp1.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be updated to netcoreapp1.1
since it supports 12 more platforms
If I'm going to do a release, I'd rather not do another one right after to include stuff that should have gone into the first one. |
you should migrate the other projects too, then I can do a |
i ❤️ this PR. and thanks a lot! |
@enricosada Perhaps I did not phrase it well, what I tried to say is that FCS dotnet core build target still uses the dotnet-fssrgen cli. The current version on nuget (3.3.0) does not contain the latest master, so I was wondering if it is possible to release another that has the latest master. This is not really related to this PR which only does the upgrade to 1.0.1, but perhaps having it run on latest dotnet core will be a better release. |
ah ok, sure, this is so near, let's just release after this is merged |
Can you please review, thanks. |
95-102 in build.fsx are using outdated dotnet cli commands, this is what's causing travis to fail |
Other than the last few build config hiccups to straighten out, LGTM. |
|
@ncave the latest versions are up |
@cloudRoutine Thanks! |
@enricosada Do you think there is a chance to get another release of this (with or without this PR)? It will help keep FCS going until the new .fsproj is supported by VS2017.