Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

[WIP] Update projects to dotnet 1.0.1 #11

Merged
merged 2 commits into from
Apr 1, 2017
Merged

[WIP] Update projects to dotnet 1.0.1 #11

merged 2 commits into from
Apr 1, 2017

Conversation

ncave
Copy link
Contributor

@ncave ncave commented Mar 28, 2017

@enricosada Do you think there is a chance to get another release of this (with or without this PR)? It will help keep FCS going until the new .fsproj is supported by VS2017.

@cloudRoutine
Copy link
Collaborator

@ncave I can do another one for you, once you've fixed the CI failures

@ncave
Copy link
Contributor Author

ncave commented Mar 29, 2017

@cloudRoutine Can you do one without this PR, that works too. Thanks a lot!

{
"title": "F# String Response Generator - dotnet cli tool",
"version": "3.3.0",
"authors": ["Don Syme","Enrico Sada","Jared Hester"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to move these too, they'll be added to the .nuspec generated by dotnet pack

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

global.json Outdated
@@ -1,4 +0,0 @@
{
"projects": [ "src", "test" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't delete this file, specify the dotnet cli version in it

<Project Sdk="FSharp.NET.Sdk;Microsoft.NET.Sdk">
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp1.0</TargetFramework>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be updated to netcoreapp1.1 since it supports 12 more platforms

@cloudRoutine
Copy link
Collaborator

If I'm going to do a release, I'd rather not do another one right after to include stuff that should have gone into the first one.

@cloudRoutine
Copy link
Collaborator

cloudRoutine commented Mar 29, 2017

you should migrate the other projects too, then I can do a 3.4.0 release for all of them at once.
plus this is probably the source of the CI failures 😉

@enricosada
Copy link
Collaborator

enricosada commented Mar 29, 2017

Do you think there is a chance to get another release of this (with or without this PR)? It will help keep FCS going until the new .fsproj is supported by VS2017

i ❤️ this PR. and thanks a lot!
but why is needed for FCS? dotnet-fssrgen is a cli tool, target should not matter (maybe i am missing something)

@ncave
Copy link
Contributor Author

ncave commented Mar 29, 2017

@enricosada Perhaps I did not phrase it well, what I tried to say is that FCS dotnet core build target still uses the dotnet-fssrgen cli. The current version on nuget (3.3.0) does not contain the latest master, so I was wondering if it is possible to release another that has the latest master. This is not really related to this PR which only does the upgrade to 1.0.1, but perhaps having it run on latest dotnet core will be a better release.

@enricosada
Copy link
Collaborator

ah ok, sure, this is so near, let's just release after this is merged

@ncave ncave changed the title Updated to dotnet 1.0.1 [WIP] Update projects to dotnet 1.0.1 Mar 29, 2017
@ncave
Copy link
Contributor Author

ncave commented Mar 30, 2017

@cloudRoutine @enricosada

Can you please review, thanks.

@cloudRoutine
Copy link
Collaborator

95-102 in build.fsx are using outdated dotnet cli commands, this is what's causing travis to fail

@cloudRoutine
Copy link
Collaborator

@cloudRoutine
Copy link
Collaborator

Other than the last few build config hiccups to straighten out, LGTM.
I'll release a new version once they're both passing. thanks @ncave

@ncave
Copy link
Contributor Author

ncave commented Mar 30, 2017

@cloudRoutine

  • The only way I could make travis CI pass was to remove the net46 target, please let me know if it's ok.
  • If not, and you're not packaging from Travis CI, perhaps we can replace the "dotnet pack" in travis.yml with "dotnet build --framework netcoreapp1.1"?
  • Also, osx keeps failing for various reasons, I made it optional in the matrix.

@cloudRoutine cloudRoutine merged commit fe3d784 into fsprojects-archive:master Apr 1, 2017
@cloudRoutine
Copy link
Collaborator

@ncave the latest versions are up

@ncave
Copy link
Contributor Author

ncave commented Apr 1, 2017

@cloudRoutine Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants