Add Longest path #79
Merged
Add Longest path #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed code comments, naming of weak component measures and tests
Developer
Restore code falsely deleted in #64
Improve Usability
Add a function to calculate the longest path of an directed acyclic FGraph
Add function to check if graph is Cyclic
Rename check functions and add the check to the compute expressions
Add simple tests for LongestPath
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## developer #79 +/- ##
=============================================
- Coverage 32.06% 28.72% -3.35%
=============================================
Files 37 38 +1
Lines 2426 2942 +516
Branches 345 365 +20
=============================================
+ Hits 778 845 +67
- Misses 1579 2026 +447
- Partials 69 71 +2 ☔ View full report in Codecov by Sentry. |
nojaf
reviewed
Dec 6, 2023
| open Graphoscope | ||
| open System.Collections.Generic | ||
|
|
||
| type LongestPath() = |
There was a problem hiding this comment.
@LibraChris nitpick: you probably didn't need the constructor on this type.
There was a problem hiding this comment.
Yes, that's correct. But this is implemented because every type annotation in this library includes this constructor. It's simply designed to conform to the established schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to Graphoscope – the Longest Path Algorithm as mentioned in #58. Additionally, it includes tests to ensure the correctness of the algorithm and checks for graph cyclicity.
Changes Made
Added Longest Path Algorithm:
Implemented an inverse Dijkstra's algorithm for finding the longest paths from a specified node in a DAG.
Introduced a new function, compute, in the Measures.LongestPath module to calculate the longest path in a directed acyclic graph (DAG).
Added a function testing if a directed graph is acyclic
Graph Cyclicity Tests:
Added tests in the Tests.Measures.LongestPathTests module to verify the correctness of the algorithm.
Included tests to ensure that the algorithm correctly identifies whether the input graph is a directed acyclic graph (DAG) or not.