Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency errors when expanding columns on a frame (#340) #341

Closed

Conversation

chrisharding
Copy link

A simple fix for #340 as discussed in the issue.

If a different solution would be better, I'd be appreciative if someone could address it quickly.

Thanks.

@tpetricek
Copy link
Member

Sorry about the long delay here. There were quite a few changes there were, unfortunately, unmerged, which caused this PR to no longer work.

@adamklein What are your thoughts on this? I think making this thread-safe would be good (although we do not really have a consistent policy on this).

Do you think there is any negative perf hit for the single-threaded scenario? (Perhaps using a .NET concurrent dictionary would be better, if that's available in .NET 4.0 that we're currently targetting...)

@tpetricek
Copy link
Member

Ping @adamklein - do you have any opinion on this?

I think making this thread safe would be good, but I'd go with concurrent dictionary instead.

@dsyme
Copy link
Member

dsyme commented Jul 27, 2018

See #394 instead

@dsyme dsyme closed this Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants