Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Introduce deadweight for tracking unused css selectors #439

Closed
wants to merge 2 commits into from

Conversation

dmitrytrager
Copy link
Contributor

This PR is created according to #225

Added Rack middleware is based on that described in this article. Although I don't see any reason to insert it exactly after Rack::Lock.

This PR inserts Deadweight as a last step of bin/quality script. It also precompiles assets in test env since we need to provide compiled css for deadweight.

Main drawback here is following:

  • this solution looks for css used in response data
  • response data is collected as a result of requests to application
  • requests are triggered by tests
  • as a result, current tests can provide not all the possible responses from the app and we can treat some selectors as 'unused' mistakenly

@timurvafin
Copy link
Member

@dmitrytrager I believe you need involve @maratfakhreev or @rustemginiyatullin to review this PR.

@dmitrytrager
Copy link
Contributor Author

@timurvafin that's for sure. I just think that time did not come yet)

@maratfakhreev
Copy link

@dmitrytrager looks awesome) Could you show how this awesome tool works? Tomorrow for example.

@timurvafin
Copy link
Member

@dmitrytrager what's the status? Please reopen when it will be updated.

@timurvafin timurvafin closed this May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants