Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test Resource component - More info Link #61

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Priyami
Copy link
Contributor

@Priyami Priyami commented Nov 11, 2021

  • I have coordinated with @IngridFuentes. So this PR depends on Testing Resource Component #60
  • Renders Resource component
  • Check the heading "Open source programs" by getByText query.
  • Check the More Info link 12 times rendered on the /resources page
  • Check when clicking More Info link routes to corresponding page /resources/resource.id
  • Check each page has resource.name using getByText on the screen

@Priyami Priyami changed the title Test Resource component Added test Resource component - More info Link Nov 15, 2021
@princiya
Copy link
Contributor

@Priyami I have approved this PR. Can we merge this or do we need to merge Ingrid's PR first?

@Priyami
Copy link
Contributor Author

Priyami commented Nov 29, 2021

@princiya Thank you for approving. Ingrid worked on the test cases in the commit testing react - eae59ea. I already merged with my commit Test Resources component -02d39a7. But in Ingrid's PR, there are some comments to work on test("resource name", () => {} , test("resource body", () => {}. If @IngridFuentes cleared out her PR, this PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants