-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
There is some merge conflicts.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need just one change. Nice job !
// Code sample | ||
code:last-child { | ||
// Hide last empty line (:empty not working, because React) | ||
> span:last-of-type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be careful, maybe add a hint on the doc about last empty line on every .twig
file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll do that. See frontend/toolbox#10
src/components/Sidebar/Sidebar.js
Outdated
|
||
import './Sidebar.css'; | ||
|
||
class Sidebar extends Component { | ||
|
||
toggleComponentsList() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's some legacy code.
} | ||
|
||
&:after { | ||
content: "\25BE"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove it (content: ''
), use the border-x below.
Will close #14