Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Update Navigation #9

Merged
merged 16 commits into from
Aug 21, 2017
Merged

Update Navigation #9

merged 16 commits into from
Aug 21, 2017

Conversation

tonifisler
Copy link
Member

@tonifisler tonifisler commented Aug 4, 2017

Will close #14

@tonifisler tonifisler requested a review from Yago August 4, 2017 13:52
@Yago
Copy link
Member

Yago commented Aug 16, 2017

There is some merge conflicts..

@tonifisler tonifisler requested review from WengerK and removed request for Yago August 21, 2017 12:46
WengerK
WengerK previously approved these changes Aug 21, 2017
Copy link
Member

@WengerK WengerK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need just one change. Nice job !

// Code sample
code:last-child {
// Hide last empty line (:empty not working, because React)
> span:last-of-type {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful, maybe add a hint on the doc about last empty line on every .twig file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do that. See frontend/toolbox#10


import './Sidebar.css';

class Sidebar extends Component {

toggleComponentsList() {
Copy link
Member

@WengerK WengerK Aug 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's some legacy code.

}

&:after {
content: "\25BE";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it (content: ''), use the border-x below.

@tonifisler tonifisler merged commit 7d43140 into master Aug 21, 2017
@tonifisler tonifisler deleted the feature/navigation branch August 21, 2017 15:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add collapsable menu sub-titles
3 participants