Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

fix colors and fonts in CSS default styles #35

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

tonifisler
Copy link
Member

@tonifisler tonifisler commented Mar 27, 2018

We have to make sure to never override the styles at all. I spent hours working on some components only to realise now that the styleguide overrides the font with the system one. Ok the font of the project is similar, but still really annoying.

@tonifisler tonifisler requested a review from Yago March 27, 2018 14:51
@tonifisler
Copy link
Member Author

In short: never use any of these:

https://stackoverflow.com/a/5612360/1722653

@dmrty
Copy link

dmrty commented May 9, 2018

I am using this PR. there is indeed some bleeding from Toolbox CSS to the component css.
The proposed commit works on my side. I've forked toolbox reader to apply it.

@tonifisler do you want me to create the associated issue ?

@tonifisler
Copy link
Member Author

Thanks @dmrty! @Yago is working on general improvements and will create a release in the near future.

We should maybe release a hotfix with this however, this is currently breaking all our styleguides... :/

@Yago Yago changed the base branch from master to dev May 3, 2019 09:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants