Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-13012 - support-angular-16-signals #450

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yuvalotem1
Copy link
Contributor

@yuvalotem1 yuvalotem1 commented Aug 7, 2023

Support angular 16 signals with backward compatibility

  • create v16 folder signals file that handle signals backward compatibility
  • create new signals functions wrapping all of our observables with toSignal
  • refactor frontegg-app.service and frontegg-auth.service - split into files

Example usage of signals

app.component.ts
export class AppComponent {
  isLoading: Signal<boolean | undefined>

  constructor(private fronteggAppService: FronteggAppService) { }
  this.isLoading = this.fronteggAppService.isLoadingSignal;
}

app.component.html
<div *ngIf="!isLoading()">
  <router-outlet></router-outlet>
</div>

@yuvalotem1 yuvalotem1 force-pushed the FR-13012-support-angular-16-signals branch from 5265a8f to e6bd925 Compare August 7, 2023 13:01
@yuvalotem1 yuvalotem1 changed the base branch from master to FR-12555-minimal-support-for-angular-16 August 7, 2023 13:02
@yuvalotem1 yuvalotem1 changed the base branch from FR-12555-minimal-support-for-angular-16 to master August 9, 2023 09:51
@yuvalotem1 yuvalotem1 force-pushed the FR-13012-support-angular-16-signals branch from 7ea7ad2 to b5dfa2e Compare August 13, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant