-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate RSS feed at /rss.xml
#8
base: master
Are you sure you want to change the base?
Conversation
definitely. what does your JSON object look like on disk at the moment? This looks good to me, the other three changes/additions that I can think of in my version at the moment are:
If you don’t have any problem with adding these, I can synthesize them as a PR from my version to here. |
Just had a play around with your version. I think we need to disambiguate fields a bit. My clips currently look like this {
"quote": "The text that is highlighted at time of clip",
"note": "The user-generated note that is typed at time of clip",
"time": 12321312311,
"tags": ["test", "example"],
"href": "https://baseurl.com/that-the-clip-comes-from"
} The server you have expects at least additional In my version of a clip, it's not necessarily sourced from a webpage (it could also be a DT document), and as such I think my
I think our treatment of |
I also like how your server groups clips according to matching |
One final point is that I excised |
@breezykermo I kind of prefer the JSONL format since it's more compatible with some other tools I have, but exposing highlights as RSS is useful. This PR keeps JSONL as the main storage format but provides a feed at
/rss.xml
. Would we be able to combine our changes in some way?