Optimize TraceMiddleware

friendsofhyperf · Oct 27, 2023 · 3362aae · 3362aae
1 parent c0ba328
commit 3362aae
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/Tracing/Middleware/TraceMiddleware.php b/src/Tracing/Middleware/TraceMiddleware.php
@@ -46,6 +46,9 @@ public function __construct(
 
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): PsrResponseInterface
     {
+        // Must be called before all.
+        $this->startTransaction($request, SentrySdk::getCurrentHub(), SentryContext::getServerName());
+
         /** @var Dispatched|null $dispatched */
         $dispatched = $request->getAttribute(Dispatched::class);
         if (
@@ -55,8 +58,6 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
             return $handler->handle($request);
         }
 
-        $this->startTransaction($request, SentrySdk::getCurrentHub(), SentryContext::getServerName());
-
         $transaction = TraceContext::getTransaction();
 
         if (! $transaction) {
@@ -157,7 +158,9 @@ private function startTransaction(ServerRequestInterface $request, HubInterface
         $context->setData($data);
 
         // Set tags
-        $tags = [];
+        $tags = [
+            'http.request.method' => strtoupper($request->getMethod()), // MUST
+        ];
         if ($this->tagManager->has('request.http.path')) {
             $tags[$this->tagManager->get('request.http.path')] = $path;
         }