Fix the bug that TracingRequestListener is not working (#462)

Co-authored-by: Deeka Wong <[email protected]>
friendsofhyperf · Nov 24, 2023 · 4b68ed5 · 4b68ed5
1 parent d4536b9
commit 4b68ed5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 37 deletions.
diff --git a/src/sentry/README.md b/src/sentry/README.md
@@ -18,32 +18,6 @@ composer require friendsofhyperf/sentry
 php bin/hyperf.php vendor:publish friendsofhyperf/sentry
 ```
 
-## Enable Request Lifecycle
-
-> will auto config in `SetRequestLifecycleListener.php`
-
-```php
-# config/autoload/server.php
-return [
-    // ...
-    'servers' => [
-        [
-            'name' => 'http',
-            'type' => Server::SERVER_HTTP,
-            'host' => '0.0.0.0',
-            'port' => 9501,
-            'callbacks' => [
-                Event::ON_REQUEST => [Hyperf\HttpServer\Server::class, 'onRequest'],
-            ],
-            'options' => [
-                'enable_request_lifecycle' => true,
-            ],
-        ],
-    ],
-    // ...
-];
-```
-
 ## Register Logger Handler
 
 ```php
@@ -106,20 +80,20 @@ class Foo
 }
 ```
 
-## Trace
+## Tracing
 
 ```php
 <?php
 
-# config/autoload/middleware.php
+# config/autoload/listeners.php
 return [
-    'http' => [
-        FriendsOfHyperf\Sentry\Tracing\Middleware\TraceMiddleware::class => PHP_INT_MAX,
-    ],
-    // rpc
-    // 'rpc' => [
-    //     FriendsOfHyperf\Sentry\Tracing\Middleware\TraceMiddleware::class,
-    // ],
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingAmqpListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingAsyncQueueListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingCommandListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingCrontabListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingDbQueryListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingKafkaListener::class,
+    FriendsOfHyperf\Sentry\Tracing\Listener\TracingRequestListener::class,
 ];
 ```
 

diff --git a/src/sentry/publish/sentry.php b/src/sentry/publish/sentry.php
@@ -95,7 +95,6 @@
             'guzzle' => env('SENTRY_TRACING_ENABLE_GUZZLE', true),
             'rpc' => env('SENTRY_TRACING_ENABLE_RPC', true),
             'redis' => env('SENTRY_TRACING_ENABLE_REDIS', true),
-            'request' => env('SENTRY_TRACING_ENABLE_REQUEST', true),
             'sql_queries' => env('SENTRY_TRACING_ENABLE_SQL_QUERIES', true),
             'missing_routes' => env('SENTRY_TRACING_ENABLE_MISSING_ROUTES', true),
         ],

diff --git a/src/sentry/src/ConfigProvider.php b/src/sentry/src/ConfigProvider.php
@@ -52,7 +52,6 @@ public function __invoke(): array
                 Listener\RequestExceptionListener::class,
                 Listener\SetRequestLifecycleListener::class,
                 Tracing\Listener\TracingDbQueryListener::class,
-                Tracing\Listener\TracingRequestListener::class,
             ],
             'annotations' => [
                 'scan' => [