Improve TracingCommandListener (#380)

* Improve `TracingCommandListener` * Update composer.json * Update sentry.php --------- Co-authored-by: Deeka Wong <[email protected]>
friendsofhyperf · Oct 27, 2023 · 1a44b3c · 1a44b3c
1 parent 215346e
commit 1a44b3c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/src/sentry/publish/sentry.php b/src/sentry/publish/sentry.php
@@ -87,6 +87,7 @@
                 'arguments' => 'command.arguments',
                 'options' => 'command.options',
                 'exit_code' => 'command.exit_code',
+                'exception.stack_trace' => 'exception.stack_trace',
             ],
             'coroutine' => [
                 'id' => 'coroutine.id',

diff --git a/src/sentry/src/Tracing/Listener/TracingCommandListener.php b/src/sentry/src/Tracing/Listener/TracingCommandListener.php
@@ -19,6 +19,7 @@
 use Hyperf\Event\Contract\ListenerInterface;
 use Sentry\SentrySdk;
 use Sentry\State\HubInterface;
+use Sentry\Tracing\SpanStatus;
 use Sentry\Tracing\TransactionContext;
 
 class TracingCommandListener implements ListenerInterface
@@ -86,6 +87,20 @@ protected function finishTransaction(HubInterface $sentry, AfterExecute $event):
             $tags[$this->tagManager->get('command.exit_code')] = $command->getName();
         }
         $transaction->setTags($tags);
+        if (method_exists($event, 'getThrowable') && $exception = $event->getThrowable()) {
+            $transaction->setStatus(SpanStatus::internalError());
+            $transaction->setTags([
+                'error' => true,
+                'exception.class' => $exception::class,
+                'exception.message' => $exception->getMessage(),
+                'exception.code' => $exception->getCode(),
+            ]);
+            if ($this->tagManager->has('command.exception.stack_trace')) {
+                $transaction->setData([
+                    $this->tagManager->get('command.exception.stack_trace') => (string) $exception,
+                ]);
+            }
+        }
         $transaction->finish(microtime(true));
     }
 }