Fix startup issues #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
force-pushed
the
fix-startup-issues
branch
from
151b606 to
92dc533
Compare
Without this, Flickwerk messes up the boot sequence of Rails enough that even loading inflections stops working. That's way there's a new "UI/Button" class in the specs now, that class does not load without the changes to the Railtie.
In the Solidus ecosystem, the user class is configurable, and many extensions patch the user class using a pattern like `Spree.user_class.prepend`. `Spree.user_class` is not a string, and can't be constantized, so we need to replace it with the actual class name before patching. This commit accomplishes that.
mamhoff
force-pushed
the
fix-startup-issues
branch
from
92dc533 to
a502f8b
Compare
tvdeyen
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to these commits, Flickwerk patches were evaluated as part of the initializer chain. These commit move them to the
config.to_preparehook, which runs after all initializers. Runningautoloader.cpath_expected_at(const_string)led to undesirable results when, for example, initializers definining inflections had not run before.This change removes the clearly defined spot to manipulate the set of patches before loading them, which we used in solidus_support 0.11 for transforming keys with
"Spree.user_class"to whatever the actual user class was. In order to be able to have that feature anyways, we add analiasesattribute that can be filled early-on with a mapping, andFlickwerk.patchwill respect that mapping. That way,Flickwerk.patcheswon't contain un-constantizable classes in the first place.