Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved data/time validation using conversion table and moment.js #170

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Improved data/time validation using conversion table and moment.js #170

merged 6 commits into from
Mar 30, 2020

Conversation

roll
Copy link
Member

@roll roll commented Mar 30, 2020

We drop usage of d3-time-format because it doesn't really validate values. Instead, we will use:

  • conversion from FD formats to JS formats
  • proper moment.js validation

@roll roll mentioned this pull request Mar 30, 2020
Closed
@roll roll merged commit 16c4163 into master Mar 30, 2020
@roll roll deleted the date-format branch March 30, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@roll