INFRA 1152 - Printing Duplicate Calls Count for Memcache in Application.log #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Id(s) : INFRA - 1152
Description :
1)In application.log the duplicate calls for Memcache (read and write) is printed by making use of dedicated counters. The count is printed for each and every requests.
2)The time unit for total duration was wrongly printed as milliseconds, that bug is addressed and it has been changed to seconds.
3)For printing the Hit and miss log in Memcache, a new condition check is added to address the edge case.( ie: When errors like Memcache unmarshall error is thrown, it is silently caught and recorded as hit previously. Now that is changed to record as miss and logged.)