[FS-211325]: React Rails integration gem changes to support dynamic node switch #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwasraj-thyagaraj
changed the title
vishwasraj-thyagaraj
changed the title
vigneshk-fd
reviewed
Oct 1, 2024
| def config_defaults(asset_host: nil, mode: ENV.fetch('RACK_ENV', 'development'), root: Dir.pwd) | ||
| { | ||
| 'asset_host' => option_from_env('asset_host') || asset_host, | ||
| 'config_path' => option_from_env('config_path') || DEFAULT_CONFIG.fetch('config_path'), | ||
| 'mode' => option_from_env('mode') || mode, | ||
| 'root' => option_from_env('root') || root, | ||
| 'root' => option_from_env('root') || Dir.pwd + '/frontend-react', |
There was a problem hiding this comment.
Not possible for us to pass as a configuration or some input, to skip hard coding here ?
vishwasraj-thyagaraj
force-pushed
the
stellar_vite_react_rails_fix
branch
from
0aba655 to
ec81d60
Compare
…for dev env" This reverts commit ec81d60.
vishwasraj-thyagaraj
force-pushed
the
stellar_vite_react_rails_fix
branch
from
2ea4616 to
cb9e513
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://freshworks.freshrelease.com/ws/FS/tasks/FS-211325
Changes made