fix: added the error message for section inside section (#959)

freshworks · Dec 5, 2024 · 277a49f · 277a49f
1 parent 46be9e2
commit 277a49f
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/packages/crayons-core/src/utils/draggable.ts b/packages/crayons-core/src/utils/draggable.ts
@@ -1,4 +1,5 @@
 import { debounce, cloneNodeWithEvents } from './index';
+import { parseBoolean } from './list-utils';
 
 //Global Variables
 let dragElement;
@@ -126,8 +127,7 @@ export class Draggable {
     const hasSectionsInFieldOptions =
       dragElement.dataProvider?.type === 'DROPDOWN' &&
       dragElement.dataProvider?.field_options &&
-      dragElement.dataProvider?.field_options.has_sections;
-
+      parseBoolean(dragElement.dataProvider?.field_options?.has_sections);
     // Check if the section already has the maximum number of fields
     const isSectionFieldLimitExceeded =
       this.dragContainer?.children?.length > 15;

diff --git a/packages/crayons-core/src/utils/list-utils.ts b/packages/crayons-core/src/utils/list-utils.ts
@@ -189,3 +189,10 @@ export function doKeyDownOperations(
     selected: false,
   };
 }
+
+export const parseBoolean = (value: any) => {
+  if (typeof value === 'string') {
+    return value === 'true';
+  }
+  return !!value;
+};
diff --git a/packages/crayons-i18n/i18n/en-US.json b/packages/crayons-i18n/i18n/en-US.json
@@ -214,7 +214,7 @@
       "deleteSection": "Delete Section",
       "disableChoiceOption": "This option is used to create a section and cannot be edited",
       "errorMessages" : {
-        "DROPDOWN" : "Dropdown fields cannot be added into sections",
+        "DROPDOWN" : "This field cannot be moved into sections",
         "MULTI_SELECT" : "Multi Select  Dropdown fields cannot be added into sections",
         "DEPENDENT_FIELD" : "Dependent fields cannot be added into sections",
         "RELATIONSHIP" : "Lookup fields cannot be added into sections",