separate EOL and deprecated devices

[grische]

Description

Adding a separation between EOL and Deprecated devices.

Motivation and Context

Adding a separation as 4/32 devices have already reached EOL a while ago and will not be "soon loose support", while at the same time, we have candidates that might loose support soon.

How Has This Been Tested?

https://map.ffmuc.net as part of freifunkMUC#70

Screenshots/links:

See https://map.ffmuc.net

Checklist:

• My code follows the code style of this project. (CI will test it anyway and also needs approval)
• My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This PR resolves #75

[maurerle]

In general, I am in favor of adding a banner for 8/64 devices - or adding them to deprecated devices.
As there currently is no removal date/timeline for these devices stated in gluon, I don't know if it is already time to add this second banner. Another solution by time would be to just wait and then use #75 :D
Personally, I do not think, that there is such a big difference, as the call to action "this old, pls replace" is the same.

To the PR itself:
There is no option to disable only one of the banners, which might be wanted by communities who do not want to disturb users with that for the next 2 years.

There is no option to filter for EOL devices instead of deprecated devices - and by changing the definition of deprecated to eol and introducing a new eol group, the filter #16 does not work correctly anymore (e.g. does not include 4/32 anymore).
I think, that the filter should include all deprecated/EOL devices.

[maurerle]

Actually, even OpenWRT does not state a timeline or that they will be "out of support soon":
https://openwrt.org/supported_devices/864_warning
Just, that the functionality might be limited and one should not buy such devices new anymore.
Which is a very different situation..? Or am I missing something?

[grische]

In general, I am in favor of adding a banner for 8/64 devices - or adding them to deprecated devices.

This was not meant as a 8/64 banner, but generally a second banner to warn for removal of devices in the future. Unlike the current warning that the devices already have lost their support.
If you look at the example devices added, those have no support anymore in Gluon v2023.2+ but are still supported in Gluon v2023.1.

• freifunk-gluon/gluon@66a33a3
• freifunk-gluon/gluon@61fc55f

There is no option to disable only one of the banners, which might be wanted by communities who do not want to disturb users with that for the next 2 years.

You can simply define an empty list and then there is nothing warned about.

Actually, even OpenWRT does not state a timeline or that they will be "out of support soon":

This is just a sample text, don't focus too much on the 8/64 here.

[grische]

There is no option to filter for EOL devices instead of deprecated devices - and by changing the definition of deprecated to eol and introducing a new eol group, the filter #16 does not work correctly anymore (e.g. does not include 4/32 anymore).

I don't understand what you mean here. All filters work fine for me:

[maurerle]

Can you rebase onto main please?

[maurerle]

Thanks - I did just deploy this in FFAC - with a small fix:
The deprecation feature has to match the name on the Map which is for the RE355:
TP-LINK RE355
https://map.aachen.freifunk.net/#!/en/map/ec086b3a33d2

For devices you don't have on your map, you can check the model drop down of this grafana dashboard:
https://stats.darmstadt.freifunk.net/d/CA5PRFmMz/gluon-census3a-dashboard

Other than that, I like it! :)

[grische]

For devices you don't have on your map, you can check the model drop down of this grafana dashboard:

I have a tool that gets a list of all devices of the major communities. If you want, I can share this with you, remind me :)
I probably just did a wrong copy&paste somewhere.

EDIT: It seems there are both variants with "v1" and lower-case TP-Link and some without and an upper-case TP-LINK, but I didn't find a 305 so assume it's the same. I added both variants now for each model.

[maurerle]

@skorpy2009 @MyIgel can you review and merge this please? :)

[Djfe]

In principle I'm on board with this change.
Issues we faced in Aachen were issues caused by browser caches.
The translation was updated prior to the javascript code. Resulting in 4/32 devices (old deprecated) being presented with the red warning label but the text for the 8/64 warning.

Maybe this can be prevented by replacing internal variable names or adjusting cache times prior to roll-out?

[Djfe]

Suggested change

	"deprecation-text": "This node is deprecated, and will be out of support soon. More information under <a href='https://openwrt.org/supported_devices/864_warning'>8/64 warning</a>.<br>If you're the owner, please replace it with an modern device!",
	"deprecation-text": "Note: This node is deprecated, and will be out of support soon. Further details can be found at <a href='https://openwrt.org/supported_devices/864_warning'>8/64 warning</a>.<br>If you're the owner, please consider replacing it with a more modern device in order to maintain access to the network.",

[Djfe]

Suggested change

	"eol-text": "This node has reached end-of-life, and is not supported anymore. More information under <a href='https://openwrt.org/supported_devices/432_warning'>4/32 warning</a>.<br>If you're the owner, please replace it with an modern device!",
	"eol-text": "Note: This node has reached end-of-life, and is not supported anymore. Further details can be found at <a href='https://openwrt.org/supported_devices/432_warning'>4/32 warning</a>.<br>If you're the owner, please consider replacing it with a more modern device in order to maintain access to the network.",

[Djfe]

Suggested change

	"eol-text": "Warnung: Dieser Knoten ist veraltet, und nicht mehr unterstützt. Mehr Infos unter <a href='https://openwrt.org/supported_devices/432_warning'>4/32 warning</a>. <br> Wenn du der Eigentümer des Gerätes bist, bitten wir dich, das Gerät zu ersetzen, um weiterhin am Netz teilnehmen zu können.",
	"eol-text": "Warnung: Dieser Knoten hat das Ende seiner Lebensdauer erreicht, und wird nicht mehr unterstützt. Weitere Infos unter <a href='https://openwrt.org/supported_devices/432_warning'>4/32 warning</a>. <br> Wenn du der Eigentümer des Gerätes bist, bitten wir dich, das Gerät zu ersetzen, um weiterhin am Netz teilnehmen zu können.",

[grische]

@Djfe this problem is unrelated to this PR here and should probably be addressed outside of this PR?

[Djfe]

In that case sorry for the noise 😅

Which problem are you referring to?
#81 (review)
or
#81 (comment)

I couldn't find any issues in the code during my review :)

[T0biii]

Issues we faced in Aachen were issues caused by browser caches.
The translation was updated prior to the javascript code. Resulting in 4/32 devices (old deprecated) being presented with the red warning label but the text for the 8/64 warning.

i guess you can fix this issue with updating also the cacheBreaker value in the config.json
when using an updated Language file

meshviewer/lib/config_default.ts

Lines 92 to 93 in 8131fae

	// Cache breaker string used when loading language json files
	cacheBreaker?: string;

[ff-mgk]

Freifunk Donau-Ries would like to use this feature too.

[T0biii]

the i guess the CI would pass if: #110 was merged

[T0biii]

this pr is currently running fine on or PR (freifunkMUC@5d45efa)
and live on our map https://map.ffmuc.net/

[GoliathLabs]

@maurerle do you know when this could be merged? Some Dependabot PRs are waiting to be merged as well.

[GoliathLabs]

Nvm. @skorpy2009 @MyIgel can you have a look at it?