Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for NanoPi R3S #3380

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

grische
Copy link
Contributor

@grische grische commented Nov 28, 2024

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other: SD card
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging) ⛔⛔⛔
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages labels Nov 28, 2024
@Djfe
Copy link
Contributor

Djfe commented Nov 28, 2024

thanks for testing the device :)
We are looking forward to deploying the device in Aachen

Does the mac address stay the same across reboots and sysupgrades? (I looked at 02_network and the code is there. I'm not trying to be annoying it's just a thing that can be verified to avoid issues for users)

I read the OpenWrt commit message:
I'm curious, whether installing to emmc works fine (not just rebooting but sysupgrades as well). This is not relevant to this PR but would be helpful for all NanoPIs that have an emmc flash chip built in.

Installation - eMMC:

-Boot from microSD
-Uncompress the OpenWRT sysupgrade.img.gz
-Flash to eMMC : dd if=x.img of=/dev/mmcblk0
-sync
-Remove microSD card
-Reboot

@grische
Copy link
Contributor Author

grische commented Dec 2, 2024

@Djfe not all R3S have an EMMC, but I was able to run a sysupgrade from OpenWRT 24.10 to gluon-next on an R3S with EMMC.

Which MAC would you like to have verified? It did get the same hostid/hostname even after an sysupgrade -n if that's what you're asking.

@Djfe
Copy link
Contributor

Djfe commented Dec 2, 2024

that answers my questions, thanks.

@herbetom
Copy link
Contributor

Now that #3370 has been merged this PR should be switched to target main and if necessary rebased. Thanks!:)

@grische grische changed the base branch from next to main December 10, 2024 10:47
@herbetom
Copy link
Contributor

Judging by the Changes and Commits of the PR it appears like a rebase will be required.

@grische grische force-pushed the add-nanopi-r3s-support branch from 83ff4b6 to aa39a94 Compare December 10, 2024 16:29
@grische grische changed the title [next] Add support for NanoPi R3S add support for NanoPi R3S Dec 10, 2024
@grische
Copy link
Contributor Author

grische commented Dec 10, 2024

@herbetom thanks. I have updated the PR!

@neocturne neocturne merged commit adbb283 into freifunk-gluon:main Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants