Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic: add gluon grub title #3366

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

T0biii
Copy link
Contributor

@T0biii T0biii commented Nov 4, 2024

change the "OpenWrt" grub title to "Gluon"

image
freifunkMUC/site-ffm#512

@github-actions github-actions bot added the 3. topic: hardware Topic: Hardware Support label Nov 4, 2024
@neocturne
Copy link
Member

Thanks! Two things to improve:

  • There is a typo in your commit message ("Titel" -> "title")
  • This should also be set for the armsr targets (either add it to armsr.inc as well, or use try_config in the generic target config)

@T0biii
Copy link
Contributor Author

T0biii commented Nov 4, 2024

thanks for the review

  • fixed typo
  • in generic sounds good for me.
    But I wasn't quite sure where exactly I hope that fits, otherwise we can move it

@T0biii T0biii changed the title x86: add gluon grub Titel generic: add gluon grub Titel Nov 4, 2024
@rotanid
Copy link
Member

rotanid commented Nov 5, 2024

thanks for the review

* fixed typo

typo is still there in PR title and commit message.

@T0biii T0biii changed the title generic: add gluon grub Titel generic: add gluon grub title Nov 5, 2024
change the "OpenWrt" grub title to "Gluon"
@T0biii
Copy link
Contributor Author

T0biii commented Nov 5, 2024

thanks for the review

* fixed typo

typo is still there in PR title and commit message.

crazy true, now fixed. I must have been asleep when I made the change

@blocktrron blocktrron merged commit d381336 into freifunk-gluon:main Nov 5, 2024
38 checks passed
@T0biii T0biii deleted the patch-1 branch November 6, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants