Use luacheck to ensure quality of code in the build, exit on error #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was für Tools müssen auf dem Build-Rechner zusätzlich installiert werden? |
|
On Mon, Nov 25, 2019 at 01:56:05AM -0800, Jason wrote:
Was für Tools müssen auf dem Build-Rechner zusätzlich installiert werden?
apt install luacheck
Vielleicht könnte der Check auch optional sein. Wenn es installiert ist
wird es ausgeführt?
Oder man aktiviert es mit einem Parameter?
…--
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
|
|
Ein Parameter hört sich gut an. |
|
Das Skript hat eine sehr inkonsistente Fehlerbehandlung. Ein globales "set -e" konsistenter und würde auch diesen Anwendungsfall abdecken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gluon project is starting to embrace linters including luacheck. When raising Code towards the gluon project, it must be ensured the proper standards are met.
Let's execute luacheck as part of our builds too.