Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanical sound support part 3 #495

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from
Draft

Mechanical sound support part 3 #495

wants to merge 32 commits into from

Commits on Nov 22, 2024

  1. initial commit

    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    73accf8 View commit details
    Browse the repository at this point in the history

  2. Individual component implements ISoundEmitter, starting with flipper … 

    …component. Have mechsoundcomponent inherit from monobehaviour directly. Update mechsoundinspector to inherit from unity editor directly and by adding a propertydrawer to handle mechsound appearance. Initialize soundlist in mechsoundscomponent.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    00c4fa9 View commit details
    Browse the repository at this point in the history

  3. Get the component that implements ISoundEmitter for pulling data to t… 

    …he MechSound Drawer. Handle when no component attached to the gameobject implements it.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    53e0bb5 View commit details
    Browse the repository at this point in the history

  4. SoundInspector updates including refactor playroundrobin and playrand… 

    …om methods, refactor handling of audio clip playing using an established gameobject's audiosource, and moved call to update event into OnEnable method. Also deleted mechsounddata and some other minor cleanup.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    fc27912 View commit details
    Browse the repository at this point in the history

  5. Further attempt to set pitch shifter value when testing sounds in the… 

    … editor.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    e0ba6a0 View commit details
    Browse the repository at this point in the history

  6. sound: Simplify sound asset and move play routine from inspector to a… 

    …sset.
    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    78c0239 View commit details
    Browse the repository at this point in the history

  7. sound: Refactor editor classes.

    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3d4848e View commit details
    Browse the repository at this point in the history

  8. sound: Get the runtime working.

    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    f6291d1 View commit details
    Browse the repository at this point in the history

  9. sounds: Clean up obsolete stuff.

    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    43a8233 View commit details
    Browse the repository at this point in the history

  10. style: Some comments and re-ordering.

    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    54351aa View commit details
    Browse the repository at this point in the history

  11. Minor fix to sound asset, in order to handle when audio clips length … 

    …changes and then playing the clips under round robin selection.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    2d5049b View commit details
    Browse the repository at this point in the history

  12. Initial audio fade implementation.

    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    489705d View commit details
    Browse the repository at this point in the history

  13. Updated fade handling. Added sound handling to the following componen… 

    …ts: plunger, drain, bumper.
    @Mr-Jay-Gatsby @arthurkehrwald
    Mr-Jay-Gatsby authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    207416d View commit details
    Browse the repository at this point in the history

  14. fix: UnityEditor reference.

    @freezy @arthurkehrwald
    freezy authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    09f4158 View commit details
    Browse the repository at this point in the history

  15. implement Stop action

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7b02f2a View commit details
    Browse the repository at this point in the history

  16. Dynamic audiosource for mechanical sound clips

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a5fecdf View commit details
    Browse the repository at this point in the history

  17. populate AudioMixer prop by searching parents 

    convenient especially prefabs.
    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7612027 View commit details
    Browse the repository at this point in the history

  18. added target sounds

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3a746d9 View commit details
    Browse the repository at this point in the history

  19. Q to exit play mode

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    0ed3e81 View commit details
    Browse the repository at this point in the history

  20. wip drop targets reset and score motor sounds

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    86bc749 View commit details
    Browse the repository at this point in the history

  21. trigger switch sounds

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c436b1a View commit details
    Browse the repository at this point in the history

  22. attempt to do target bank reset sound

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d5cb350 View commit details
    Browse the repository at this point in the history

  23. Update DropTargetBankApi.cs

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3b895c2 View commit details
    Browse the repository at this point in the history

  24. wip drop targets reset and score motor sounds

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    d25ec19 View commit details
    Browse the repository at this point in the history

  25. button to add MechSound with default volume=1

    @linojon @arthurkehrwald
    linojon authored and arthurkehrwald committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    491b5c3 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Apply default values to MechSound instances

    @arthurkehrwald
    arthurkehrwald committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    25b528a View commit details
    Browse the repository at this point in the history

  2. Fix UNT0026 warning

    @arthurkehrwald
    arthurkehrwald committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    b38ae1d View commit details
    Browse the repository at this point in the history

  3. Remove unused variable

    @arthurkehrwald
    arthurkehrwald committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    5416805 View commit details
    Browse the repository at this point in the history

  4. Do not change open scene when previewing sounds

    @arthurkehrwald
    arthurkehrwald committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0187995 View commit details
    Browse the repository at this point in the history

  5. DropTargetBankComponent doesn't inherit MainRenderableComponent

    @arthurkehrwald
    arthurkehrwald committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    0ffc529 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Complete score motor sound support

    @arthurkehrwald
    arthurkehrwald committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    3bdfed2 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2024

  1. Rewrite inspectors and sound playback

    @arthurkehrwald
    arthurkehrwald committed Dec 3, 2024
    Configuration menu
    Copy the full SHA
    b2fb22b View commit details
    Browse the repository at this point in the history