Add parachain-staking pallet
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as ready for review
ghost
self-assigned this
|
I realized this shouldn't be added to runtime yet, since we do the upgrade at the end of the sprint |
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
…parachain-staking
magecnion
approved these changes
Feb 2, 2024
asiniscalchi
requested changes
Feb 2, 2024
asiniscalchi
requested changes
Feb 2, 2024
| @@ -242,13 +242,18 @@ orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-li | |||
| orml-xcm-support = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
| orml-xtokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
|
|
|||
| # Other pallets | |||
| # (wasm) | |||
| substrate-fixed = { git = "https://github.com/encointer/substrate-fixed", default-features = false } | |||
There was a problem hiding this comment.
what's this dependency for ?
There was a problem hiding this comment.
crate for fixed point arithmetic used by the parachain-staking pallet
There was a problem hiding this comment.
it's published on crates.io : https://crates.io/crates/substrate-fixed
There was a problem hiding this comment.
asiniscalchi
approved these changes
Feb 2, 2024
| @@ -242,13 +242,18 @@ orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-li | |||
| orml-xcm-support = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
| orml-xtokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
|
|
|||
| # Other pallets | |||
| # (wasm) | |||
| substrate-fixed = { git = "https://github.com/encointer/substrate-fixed", default-features = false } | |||
There was a problem hiding this comment.
it's published on crates.io : https://crates.io/crates/substrate-fixed
| @@ -242,13 +242,18 @@ orml-traits = { git = "https://github.com/open-web3-stack/open-runtime-module-li | |||
| orml-xcm-support = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
| orml-xtokens = { git = "https://github.com/open-web3-stack/open-runtime-module-library", branch = "polkadot-v1.1.0", default-features = false } | |||
|
|
|||
| # Other pallets | |||
| # (wasm) | |||
| substrate-fixed = { git = "https://github.com/encointer/substrate-fixed", default-features = false } | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parachain-stakingpallet added topallets. No modifications, copied as it is