Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart Mappings & Data Labels #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Chart Mappings & Data Labels #3

wants to merge 5 commits into from

Conversation

jonmuell
Copy link
Contributor

You can now manipulate the data labels in the chart widgets (e.g. to localize the date format) and provide a custom chart mapping in JSON format (useful for translation).

@jonmuell
Copy link
Contributor Author

@chaaya @damoonrashidi @chlirre

With this PR it is also possible to change the date format as in #4, however, I solved this differently: In #4 you specify the pattern and can use a parse function in chartMappings.ts. I'd like to keep chartMappings.ts clean as I need to provide it as JSON from our Angular app. Therefore I added a DataLabelTransformer which does basically the same but if you want to use it you have to do the whole logic of parsing and transforming the date yourself. The way #4 solves this might be simpler but the problem is that call_length_distribution has a data label missed which we need to translate. To access it we can use the DataLabelTransformer aswell, so my opinion is to stick with this one as it can solve both problems.

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant