Gather required facts if relevant keys in ansible_facts are missing #1102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an additional tasks to gather relevant facts if the corresponding keys (i.e.
distribution
,distribution_version
,distribution_major_version
,os_family
) are not already present in theansible_facts
dict.Since the documentation does not mention that fact gathering is required before using certain roles, this prevents errors such as #962
One could also add
when: ansible_facts_fqdn is not defined ...
.However, this is not always required (e.g. when using the role
ipaclient
onlytasks/install.yml
usesansible_facts.fqdn
) andansible_facts.fqdn
will always be preset after usingansible.builtin.setup
withgather_subset: min
.