-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New utils method that returns the lists of members. #1020
base: master
Are you sure you want to change the base?
Conversation
8c0c698
to
ed98f82
Compare
Please add information about |
ed98f82
to
ba7eec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add the new test playbooks to the "*_client_context" test playbook.
Client context test is important for any method dealing with lists as lists are returned as tuples in this case.
About the client context tests, I'd like to have a single "test_*_client_context.yml" file per module, so you can simply add the regular test file as "import_playbook" to the existing client context test playbook. As this might be debatable, @t-woerner, do you agree? |
Thanks @rjeffman, it makes sense as for example there are already |
6680c05
to
c3d7131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I really like the idiom allowed by concat_list_attr
. Thank you for this!
93a56a6
to
f56b689
Compare
Extend netgroup and sudorule modules to support external users and hosts wherever possible. Add tests for ipanetgroup and ipasudorule. Problem statement: ``` - name: Ensure sudorule is present with users and hosts (action member) ipasudorule: name: testrule2 user: - external-user action: member - name: Ensure sudorule is present with users and hosts (action member) again ipasudorule: name: testrule2 user: - external-user action: member ``` After execution of the first task with external users ansible returns changed as expected, after second it still returns changed - it's a bug. This PR fixes it. After the second task ansible will return ok. "External" entities are: for `ipasudorule`: `externalhost, externaluser, ipasudorunasextuser, ipasudorunasextgroup` for `ipanetgroup`: `externalhost` Signed-off-by: Denis Karpelevich <[email protected]>
Extend netgroup and sudorule modules to support external
users and hosts wherever possible.
Add tests for ipanetgroup and ipasudorule.
Problem statement:
After execution of the first task with external users ansible returns
changed
as expected, after second it still returnschanged
- it's a bug. This PR fixes it. After the second task ansible will returnok
."External" entities are:
for
ipasudorule
:externalhost, externaluser, ipasudorunasextuser, ipasudorunasextgroup
for
ipanetgroup
:externalhost